[PATCH] D37065: Ensure standard pseudo instructions (TargetOpcode::*) are compatible with guessInstructionProperties=0
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 23 11:44:31 PDT 2017
qcolombet added a comment.
Hi Alex,
I see that we stuck to hasSideEffects = 1 for BUNDLE, EH_LABEL and so on (the ones I marked with Ditto at some point).
Are we going to do the same thing as PHIs here, or do we plan to leave them with that flag ON?
I am not sure it is the right thing to do, but assuming it is, could you add a comment before each of them to explain why they have side effects.
Cheers,
-Quentin
https://reviews.llvm.org/D37065
More information about the llvm-commits
mailing list