[PATCH] D39125: [inlineasm] Fix crash when number of matched input constraint operands overflows signed char
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 23 09:37:56 PDT 2017
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with the minor cleanups
================
Comment at: lib/IR/InlineAsm.cpp:166
scInfo.MatchingInput = ConstraintsSoFar.size();
+ assert(scInfo.MatchingInput>=0);
} else {
----------------
Spaces around >=
================
Comment at: lib/IR/InlineAsm.cpp:174
ConstraintsSoFar[N].MatchingInput = ConstraintsSoFar.size();
+ assert(ConstraintsSoFar[N].MatchingInput>=0);
}
----------------
Ditto
================
Comment at: test/CodeGen/AMDGPU/InlineAsmCrash.ll:1
+; RUN: llc -march=amdgcn -verify-machineinstrs < %s
+
----------------
This should check something in the output
https://reviews.llvm.org/D39125
More information about the llvm-commits
mailing list