[PATCH] D39148: [COFF] Add support for /WX

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Options.td:87-88
 def force_unresolved : F<"force:unresolved">;
+def WX : F<"WX">, HelpText<"Treat warnings as errors">;
+def WX_no : F<"WX:no">, HelpText<"Don't treat warnings as errors">;
 
----------------
smeenai wrote:
> ruiu wrote:
> > compnerd wrote:
> > > You should move this down and use the `QB` multiclass instead.
> > Yes, you can use `QB` instead.
> `QB` is defined in the section for unimplemented arguments, so if anything I'd want to move `QB` up. However, as best as I can tell, `QB` doesn't allow specifying help text. We already have `B`, which is what I was using originally, but that only allows specifying help text for the `:no` part. I could extend either of those macros to accept a help text for both options or introduce a new multiclass, of course.
Makes sense. I'm fine with this.


https://reviews.llvm.org/D39148