[PATCH] D39172: [ELF] When placing orphans, handle case when last section is dead

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 22 17:36:14 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.cpp:1014
+
+  auto P = [](BaseCommand *Cmd) {
+    auto *OS = dyn_cast<OutputSection>(Cmd);
----------------
nit: we usually use P for a pair, so maybe `Pred` is a better name.


Repository:
  rL LLVM

https://reviews.llvm.org/D39172





More information about the llvm-commits mailing list