[PATCH] D39139: LLD/ELF: Allow targets to set e_flags

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 22 17:31:55 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Arch/MipsArchTree.cpp:284
 
 template <class ELFT> uint32_t elf::calcMipsEFlags() {
   std::vector<FileFlags> V;
----------------
t-tye wrote:
> Would it be better to just rename this calcEFlags to match how the other targets are now?
Yes, please just rename it.


https://reviews.llvm.org/D39139





More information about the llvm-commits mailing list