[PATCH] D39028: Irreducible loop metadata for more accurate block frequency under PGO.
Hiroshi Yamauchi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 20 18:10:25 PDT 2017
yamauchi added inline comments.
================
Comment at: include/llvm/Analysis/BlockFrequencyInfoImpl.h:1166
+ NumHeadersWithWeight++;
+ if (HeaderWeight.getValue())
+ Dist.addLocal(HeaderNode, HeaderWeight.getValue());
----------------
davidxl wrote:
> Is this check needed?
Yes, Dist.addLocal will has an assert against incoming zero value.
https://reviews.llvm.org/D39028
More information about the llvm-commits
mailing list