[PATCH] D38427: Graph builder implementation.

Vlad Tsyrklevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 17:33:03 PDT 2017


vlad.tsyrklevich added inline comments.


================
Comment at: unittests/tools/llvm-cfi-verify/FileAnalysis.cpp:68
+    if (auto Err = Analysis.initialiseDisassemblyMembers()) {
+      handleAllErrors(std::move(Err), [](const ErrorInfoBase &E) {});
+      SuccessfullyInitialised = false;
----------------
Could we (1) break the x86 test changes out into a follow-up CL and (2) check the error message to make sure we only skip tests for the specific error message we expect to see? I want to make sure we don't break something else in the future that accidentally disables unit tests without us realizing.


https://reviews.llvm.org/D38427





More information about the llvm-commits mailing list