[PATCH] D29934: [RISCV 12/n] Codegen support for memory operations

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM

Thanks for splitting.  Tracking the pieces is now much easier.



================
Comment at: lib/Target/RISCV/RISCVInstrInfo.cpp:39
+                                 bool KillSource) const {
+  if (!RISCV::GPRRegClass.contains(DestinationRegister, SourceRegister)) {
+    llvm_unreachable("Impossible reg-to-reg copy");
----------------
This looks like it can just be an assert.


https://reviews.llvm.org/D29934