[PATCH] D38973: COFF: Give manifest resource file a name.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 12:42:21 PDT 2017


pcc added a comment.

In https://reviews.llvm.org/D38973#902376, @thakis wrote:

> > because this requires Windows an
>
> Why does this require Windows? lld does manifest stuff natively nowadays, so this should be testable on non-Windows I think.


That's true. Our implementation of the Windows maniifest tool appears to require libxml, so I suppose we could gate the test on the libxml2 feature. We might also want to do something like https://reviews.llvm.org/D38977 to test this on Windows as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D38973





More information about the llvm-commits mailing list