[PATCH] D39016: Add Percent Symbol In PPC Registers for Linux

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg requested changes to this revision.
joerg added a comment.
This revision now requires changes to proceed.

The patch is not acceptable in the current form. This includes fixing the memory leaks.

On PowerPC, three different output forms have to be supported:
(1) register name without percent on Darwin
(2) plain register number on AIX
(3) register name with percent OR plain register number on anything else
I don't think there is a big reason for supporting the second option of (3) though. The least amount of change is to introduce a predicate that checks for !Darwin && !AIX and then prints the % in the assembler printer. It is better to just pass down the target directly than deciding in the higher layers which forms should be choosen.


https://reviews.llvm.org/D39016