[PATCH] D39038: Mark lld/test/ELF as flaky.

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 00:34:55 PDT 2017


On Thu, Oct 19, 2017 at 7:58 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Michael, what is the correct way to handle std::thread's constructor
> failing when exceptions are disabled?
>
> Cheers,
> Rafael
>

There isn't a way. I checked both libc++ and libstdc++ and they both call
abort if creating a thread fails with exceptions disabled. I wonder if it's
worth adding a way to handle this to the std.

As for now, if we want to handle this case we'll need our own thread
creation mechanism.

- Michael Spencer



>
> NAKAMURA Takumi via Phabricator via llvm-commits
> <llvm-commits at lists.llvm.org> writes:
>
> > chapuni added a comment.
> >
> > I guess the constructor std::thread(F) fails, then its method, detach()
> crashes.
> > If we live with -fno-exceptions, I think we may rewrite Parallel.cpp w/o
> C++11 std::thread, but with pthreads, to catch failure in pthread_create.
> >
> > Or, could I increase any resources in ulimit/kernel? I tried idea that I
> knew.
> > I will attempt to find out with -fexceptions which error would raise.
> >
> > FYI, I am using 36-core (72 logical processors) host.
> >
> >
> > Repository:
> >   rL LLVM
> >
> > https://reviews.llvm.org/D39038
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171020/5bf62d8b/attachment.html>


More information about the llvm-commits mailing list