[PATCH] D39088: [AArch64][SVE] Asm: Replace 'IsVector' by 'RegKind' in AArch64AsmParser (NFC)

[Javed Absar via Phabricator via llvm-commits]

javed.absar added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:62
 
+enum class RegKind {Scalar, NeonVector, SVEVector };
+
----------------
fhahn wrote:
> Would it make sense to use something more generic for the names here, like `ScalableVector`?
It seems to be it would be more maintainable to split it 
- RegKind { Scalar, Vector };
 and then 
enum class VectorKind { NeonVector, SVEVector};

This might simplify the checking logic further down.


https://reviews.llvm.org/D39088