[llvm] r316158 - Revert rL316156 due to failure on APFloatTest.fromToStringSpecials

[Max Kazantsev via llvm-commits]

Author: mkazantsev
Date: Thu Oct 19 05:22:39 2017
New Revision: 316158

URL: http://llvm.org/viewvc/llvm-project?rev=316158&view=rev
Log:
Revert rL316156 due to failure on APFloatTest.fromToStringSpecials

Modified:
    llvm/trunk/lib/Support/APFloat.cpp
    llvm/trunk/unittests/ADT/APFloatTest.cpp

Modified: llvm/trunk/lib/Support/APFloat.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/APFloat.cpp?rev=316158&r1=316157&r2=316158&view=diff
==============================================================================
--- llvm/trunk/lib/Support/APFloat.cpp (original)
+++ llvm/trunk/lib/Support/APFloat.cpp Thu Oct 19 05:22:39 2017
@@ -2543,12 +2543,12 @@ IEEEFloat::convertFromDecimalString(Stri
 }
 
 bool IEEEFloat::convertFromStringSpecials(StringRef str) {
-  if (str.equals("inf") || str.equals("INFINITY") || str.equals("+Inf")) {
+  if (str.equals("inf") || str.equals("INFINITY")) {
     makeInf(false);
     return true;
   }
 
-  if (str.equals("-inf") || str.equals("-INFINITY") || str.equals("-Inf")) {
+  if (str.equals("-inf") || str.equals("-INFINITY")) {
     makeInf(true);
     return true;
   }

Modified: llvm/trunk/unittests/ADT/APFloatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/APFloatTest.cpp?rev=316158&r1=316157&r2=316158&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/APFloatTest.cpp (original)
+++ llvm/trunk/unittests/ADT/APFloatTest.cpp Thu Oct 19 05:22:39 2017
@@ -849,22 +849,6 @@ TEST(APFloatTest, fromDecimalString) {
   EXPECT_EQ(2.71828, convertToDoubleFromString("2.71828"));
 }
 
-TEST(APFloatTest, fromToStringSpecials) {
-  auto roundTrip = [] (const char* str) {
-    return convertToString(convertToDoubleFromString(str), 0, 3).c_str();
-  };
-  EXPECT_STREQ("+Inf", roundTrip("+Inf"));
-  EXPECT_STREQ("+Inf", roundTrip("INFINITY"));
-  EXPECT_STREQ("+Inf", roundTrip("inf"));
-  EXPECT_STREQ("-Inf", roundTrip("-Inf"));
-  EXPECT_STREQ("-Inf", roundTrip("-INFINITY"));
-  EXPECT_STREQ("-Inf", roundTrip("-inf"));
-  EXPECT_STREQ("NaN", roundTrip("NaN"));
-  EXPECT_STREQ("NaN", roundTrip("nan"));
-  EXPECT_STREQ("NaN", roundTrip("-NaN"));
-  EXPECT_STREQ("NaN", roundTrip("-nan"));
-}
-
 TEST(APFloatTest, fromHexadecimalString) {
   EXPECT_EQ( 1.0, APFloat(APFloat::IEEEdouble(),  "0x1p0").convertToDouble());
   EXPECT_EQ(+1.0, APFloat(APFloat::IEEEdouble(), "+0x1p0").convertToDouble());