[PATCH] D38846: [ELF] - Linkerscript: fix issue with SUBALIGN.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/ScriptParser.cpp:649
+    if (!isPowerOf2_64(Alignment))
+      error(Loc + ": alignment must be power of 2");
+    return Alignment;
----------------
grimar wrote:
> ruiu wrote:
> > You should return 1 instead of some erroneous value.
> It does not make sence I think. 
> What we should do here is to report an error and a value that is not 0, so that possible alignTo() call will not asset.
> My code already do that.
"report an error and a value" -> "report an error and **return** a value"


https://reviews.llvm.org/D38846