[llvm] r316147 - [Coverage] Simplify r316141. NFC.

[Vedant Kumar via llvm-commits]

Author: vedantk
Date: Wed Oct 18 23:16:23 2017
New Revision: 316147

URL: http://llvm.org/viewvc/llvm-project?rev=316147&view=rev
Log:
[Coverage] Simplify r316141. NFC.

Modified:
    llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp
    llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp

Modified: llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp?rev=316147&r1=316146&r2=316147&view=diff
==============================================================================
--- llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp (original)
+++ llvm/trunk/lib/ProfileData/Coverage/CoverageMapping.cpp Wed Oct 18 23:16:23 2017
@@ -672,13 +672,13 @@ CoverageData CoverageMapping::getCoverag
 }
 
 LineCoverageStats::LineCoverageStats(
-    ArrayRef<const coverage::CoverageSegment *> LineSegments,
-    const coverage::CoverageSegment *WrappedSegment, unsigned Line)
+    ArrayRef<const CoverageSegment *> LineSegments,
+    const CoverageSegment *WrappedSegment, unsigned Line)
     : ExecutionCount(0), HasMultipleRegions(false), Mapped(false), Line(Line),
       LineSegments(LineSegments), WrappedSegment(WrappedSegment) {
   // Find the minimum number of regions which start in this line.
   unsigned MinRegionCount = 0;
-  auto isStartOfRegion = [](const coverage::CoverageSegment *S) {
+  auto isStartOfRegion = [](const CoverageSegment *S) {
     return !S->IsGapRegion && S->HasCount && S->IsRegionEntry;
   };
   for (unsigned I = 0; I < LineSegments.size() && MinRegionCount < 2; ++I)

Modified: llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp?rev=316147&r1=316146&r2=316147&view=diff
==============================================================================
--- llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp (original)
+++ llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp Wed Oct 18 23:16:23 2017
@@ -647,49 +647,14 @@ TEST_P(CoverageMappingTest, test_line_co
 
   CoverageData Data = LoadedCoverage->getCoverageForFile("file1");
 
-  unsigned NumLineStats = 0;
+  unsigned Line = 0;
+  unsigned LineCounts[] = {20, 20, 20, 20, 10, 10, 10, 10, 10, 0, 0};
   for (const auto &LCS : getLineCoverageStats(Data)) {
-    ++NumLineStats;
-    (void)LCS;
+    ASSERT_EQ(Line + 1, LCS.getLine());
+    ASSERT_EQ(LineCounts[Line], LCS.getExecutionCount());
+    ++Line;
   }
-  ASSERT_EQ(11U, NumLineStats);
-
-  LineCoverageIterator LCI{Data};
-
-  ASSERT_EQ(1U, LCI->getLine());
-  ASSERT_EQ(20ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(2U, LCI->getLine());
-  ASSERT_EQ(20ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(3U, LCI->getLine());
-  ASSERT_EQ(20ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(4U, LCI->getLine());
-  ASSERT_EQ(20ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(5U, LCI->getLine());
-  ASSERT_EQ(10ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(6U, LCI->getLine());
-  ASSERT_EQ(10ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(7U, LCI->getLine());
-  ASSERT_EQ(10ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(8U, LCI->getLine());
-  ASSERT_EQ(10ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(9U, LCI->getLine());
-  ASSERT_EQ(10ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(10U, LCI->getLine());
-  ASSERT_EQ(0ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(11U, LCI->getLine());
-  ASSERT_EQ(0ULL, LCI->getExecutionCount());
-  ++LCI;
-  ASSERT_EQ(LCI, LCI.getEnd());
+  ASSERT_EQ(11U, Line);
 }
 
 TEST_P(CoverageMappingTest, uncovered_function) {