[PATCH] D29934: [RISCV 12/n] Codegen support for memory operations

[Philip Reames via Phabricator via llvm-commits]

reames added subscribers: test, reames.
reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/CodeGen/RISCV/alu.ll:164
+
+; Materialize constants
+
----------------
These tests have nothing to do with memory access.  You should separate a patch which implements this support.


================
Comment at: test/CodeGen/RISCV/mem.ll:140
+
+; Check load and store to a global
+ at G = global i32 0
----------------
It looks like there's non-trivial support required specifically for globals.  This should probably be separated into it's own patch.

You might also be able to start with a simpler (orthogonal) test.  Consider: 
define i32* @test() {
  return i32* @G
}


https://reviews.llvm.org/D29934