[PATCH] D39067: [LLD] [COFF] Move MinGW specific functions/classes to a separate file. NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 15:15:14 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LLVM with these style changes.



================
Comment at: COFF/MinGW.cpp:19-20
+
+namespace lld {
+namespace coff {
+
----------------
Instead of enclosing the entire file with `namespace`, add `coff::` to non-static functions just like we do in ELF.


================
Comment at: COFF/MinGW.h:21
+
+using llvm::StringSet;
+
----------------
Instead of doing this, please include LLVM.h just like other headers in lld do.


https://reviews.llvm.org/D39067





More information about the llvm-commits mailing list