[PATCH] D38937: [LLD] [COFF] Exclude certain static libraries and object files when exporting all symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D38937#901090, @ruiu wrote:

> I don't see a reason to use OO over plain functions in this patch, but this is probably okay.


The reason for OO was (as you probably guess) keeping the sets around for each invocation. It might be a case of premature optimization. The alternative while keeping them around, with plain functions, would be to store the sets in the calling context and passing them to the function, and at that point, wrapping them up in a class seemed to simplify the code.

> We can revisit it later. But I feel we are having too many functions for MinGW in Driver.cpp, so I was thinking that it might be a good idea to great MinGW.{h,cpp} in the COFF directory to put MinGW-related stuff there. What do you think?

That's probably sensible. Do you want a preparatory patch doing that, and then rebasing this one on top of that?


https://reviews.llvm.org/D38937