[PATCH] D39058: [ELF] - Simplify reporting of garbage collected sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 12:18:40 PDT 2017


ruiu added a comment.

I think I like the direction of this patch.



================
Comment at: ELF/LinkerScript.cpp:286
     for (InputSectionBase *Sec : InputSections) {
-      if (Sec->Assigned)
+      if (Sec->Assigned || !Sec->Live)
         continue;
----------------
Question: is it possible that a section is assigned to some output section but is not live? It sounds like a bad state to me.


https://reviews.llvm.org/D39058





More information about the llvm-commits mailing list