[PATCH] D35844: Correct dwarf unwind information in function epilogue

[Violeta Vukobrat via Phabricator via llvm-commits]

violetav added a comment.

> Could you try changing it to not add MachineInstr::isDirective()?

Would changing the name 'isDirective()' into something more sensible and adding a description be acceptable?
Or maybe moving it to BranchFolding and using isMetaInstruction() in TailDuplication?
Or leaving the 'isDebugValue() || isCFIInstruction()' condition without adding a special method for this particular case?

I know that isDirective() would currently be used only in BranchFolding, but I suspect that it will also need to be used elsewhere when support for CFI instructions in epilogue is added to other targets.


Repository:
  rL LLVM

https://reviews.llvm.org/D35844