[PATCH] D38314: [mips] Adds support for R_MIPS_26, HIGHER, HIGHEST relocations in RuntimeDyld

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 03:08:35 PDT 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline nits addressed.



================
Comment at: lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.cpp:119
                << format("%x", Type) << " Addend: 0x" << format("%llx", Addend)
+               << " Offset: " << format("%x", Offset)
+               << " SID: " << format("%d", SectionID)
----------------
"%x" -> "%llx" PRIx64


================
Comment at: lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.cpp:316
+               << " Addend: " << format("%x", Addend)
+               << " SymOffset: " << format("%x", Offset) << "\n");
 
----------------
"%x" -> "%llx" PRIx64


Repository:
  rL LLVM

https://reviews.llvm.org/D38314





More information about the llvm-commits mailing list