[PATCH] D38918: Update successor after branch relaxation in ARM

Wed Oct 18 02:08:56 PDT 2017

rovka added a comment.

In https://reviews.llvm.org/D38918#899993, @sabuasal wrote:

> I only cared about not having the Dest BB as a successor because it might cause scheduling issues and\or labels not being emitted, having extra successor wont.

Do you have an example that you could add as a MIR test for this patch? (If you get stuck parsing MIR constant pools, it's ok to pass IR through llc and just -stop-after this pass)

================
Comment at: lib/Target/ARM/ARMConstantIslandPass.cpp:1730
+  // If we split the Block MI belongs to the new one. After deleting MI
+  // DestBB is no longer a successor.
+  if (SplitBlock)
----------------
I think you should make sure this is true (i.e. check that DestBB is not used by any of the other terminators in SplitBlock). 

Repository:
  rL LLVM

https://reviews.llvm.org/D38918