[PATCH] D39041: [Support] Remove an outdated comment.

Eric Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 01:22:23 PDT 2017


ioeric created this revision.

The comment about `removeArgument` seems to be outdated after
https://reviews.llvm.org/rL227345

I came across a use case where options only live in a function scope and need to
be unregistered before destruction, and It seems that `removeArgument` works
fine now after https://reviews.llvm.org/rL227345


https://reviews.llvm.org/D39041

Files:
  include/llvm/Support/CommandLine.h


Index: include/llvm/Support/CommandLine.h
===================================================================
--- include/llvm/Support/CommandLine.h
+++ include/llvm/Support/CommandLine.h
@@ -333,10 +333,7 @@
   //
   void addArgument();
 
-  /// Unregisters this option from the CommandLine system.
-  ///
-  /// This option must have been the last option registered.
-  /// For testing purposes only.
+  // Unregisters this option from the CommandLine system.
   void removeArgument();
 
   // Return the width of the option tag for printing...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39041.119439.patch
Type: text/x-patch
Size: 547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171018/e4cfa2e1/attachment.bin>


More information about the llvm-commits mailing list