[PATCH] D39020: Statically link llvm-cfi-verify's libraries.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 17:33:19 PDT 2017


pcc added inline comments.


================
Comment at: tools/llvm-cfi-verify/lib/CMakeLists.txt:13
+llvm_update_compile_flags(LLVMCFIVerify)
+llvm_map_components_to_libnames(libs ${LLVM_LINK_COMPONENTS})
+target_link_libraries(LLVMCFIVerify ${libs})
----------------
Can you move the list of dependencies into this statement?


================
Comment at: unittests/tools/llvm-cfi-verify/CMakeLists.txt:18
+  target_link_libraries(CFIVerifyTests LLVMCFIVerify)
+  export_executable_symbols(CFIVerifyTests)
 endif()
----------------
Why is this line necessary?


https://reviews.llvm.org/D39020





More information about the llvm-commits mailing list