[PATCH] D39023: lit: Improve %: normalization.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:870-879
+    # "%:[STpst]" are normalized paths without colons and without a leading
+    # slash. This should match the normalization of embedded paths in linkrepro
+    # tar files.
+    substitutions.extend([
+            ('%:s', colonNormalizePath(sourcepath)),
+            ('%:S', colonNormalizePath(sourcedir)),
+            ('%:p', colonNormalizePath(sourcedir)),
----------------
I think the `%:` substitutions are used outside of linkrepro tar files, so it seems odd to change the semantics of ALL substitutions just for the purposes of a small number of tests.  

We already have `%:` (remove :), and `%/` (convert `\` to `/`).  Maybe adding `%:/` (remove : *and* convert `\` to `/`) is a better choice?  This way if for some reason someone still needs to use the existing semantics of `%:`, they can get it.




https://reviews.llvm.org/D39023