[PATCH] D38906: AMDGPU/SI: Implement d16 support buffer_load_format and tbuffer_load_format intrinsics

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 15:40:26 PDT 2017


cfang added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3258-3261
+      MachineMemOperand *MMO = MF.getMachineMemOperand(
+                                   MachinePointerInfo(),
+                                   MachineMemOperand::MOLoad,
+                                   VT.getStoreSize(), VT.getStoreSize());
----------------
arsenm wrote:
> This should be moved into getTgtMemIntrinsic so the MMO already exists
I could not understand your intention here. Can you be more specific how to move this to "bool SITargetLowering::getTgtMemIntrinsic"? 
And how to get MMO?  Thanks.


https://reviews.llvm.org/D38906





More information about the llvm-commits mailing list