[PATCH] D38977: COFF: Add type server pdb files to linkrepro tar file.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 14:57:55 PDT 2017


pcc added inline comments.


================
Comment at: lld/test/COFF/linkrepro-pdb.test:1
+REQUIRES: x86, shell
+
----------------
zturner wrote:
> I don't believe this test needs `requires shell` does it?  That will basically prevent it from running on Windows.
I think the linkrepro tests do in fact require not-Windows, perhaps because of path length limitations. I think Rui did try to enable them on Windows at one point, but that change had to be reverted (see rL291527).


https://reviews.llvm.org/D38977





More information about the llvm-commits mailing list