[PATCH] D37467: Add a new pass to speculate around PHI nodes with constant (integer) operands when profitable.
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 17 14:22:49 PDT 2017
MatzeB added a comment.
Without having read the code yet:
> We could in theory make it part of the codegen pass
> pipeline, but there doesn't really seem to be a good reason for that --
> it isn't "lowering" in any sense and only relies on pretty standard cost
> model based TTI queries, so it seems to fit well with the "optimization"
> pipeline model.
This does sound like a CodeGen pass to me! Not all of CodeGen is lowering, we do have optimization passes there too. And the fact that TTI is used is another indicator that this is a machine specific pass. This being part of CodeGen would also allow targets to not add the pass to the pipeline if it doesn't help them.
https://reviews.llvm.org/D37467
More information about the llvm-commits
mailing list