[PATCH] D38997: Support formatting formatv_objects.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: include/llvm/Support/FormatVariadicDetails.h:34
 public:
-  explicit provider_format_adapter(T &&Item) : Item(Item) {}
+  explicit provider_format_adapter(T &&Item) : Item(std::forward<T>(Item)) {}
 
----------------
This looks incorrect?  `T` is not deduced here, so `std::forward<T>(Item)` is not using a forwarding reference.  I think the code before was correct, was it causing a problem?


https://reviews.llvm.org/D38997