[PATCH] D36875: [Sparc] efficient pattern for UINT_TO_FP conversion

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

Maybe a test for bitcast from int to float, without the uitofp, too?



================
Comment at: lib/Target/Sparc/SparcISelLowering.cpp:1392
 
+SDValue SparcTargetLowering::LowerBITCAST(SDValue Op, SelectionDAG &DAG) const {
+  SDLoc dl(Op);
----------------
Move both these functions down below with the rest of the Lower* members (near where LowerUINT_TO_FP was previously) -- this section is for the calling convention lowering.


================
Comment at: test/CodeGen/SPARC/uint_to_fp.ll:1
+
+;
----------------
Tests for i64?
Tests for converting to float?

Do these overlap with some tests from "float.ll"? (If so, seems reasonable to pull those out here, too.)



================
Comment at: test/CodeGen/SPARC/vis3.ll:1
+
+;
----------------
Merge with the previous file?


https://reviews.llvm.org/D36875