[PATCH] D38846: [ELF] - Linkerscript: fix issue with SUBALIGN.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 08:19:23 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:405-406
       if (Sec->SubalignExpr) {
-        uint32_t Subalign = Sec->SubalignExpr().getValue();
+        uint32_t Subalign =
+            std::max((uint64_t)1, Sec->SubalignExpr().getValue());
         for (InputSectionBase *S : V)
----------------
You should report an error if Subalign is not a power of two.


https://reviews.llvm.org/D38846





More information about the llvm-commits mailing list