[PATCH] D38988: [PowerPC] Use helper functions to check sign-/zero-extended value

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

This seems like a perfectly valid thing to do. Please add a test case before this can proceed though.
I would imagine that one of the extra 5000 eliminated compare instructions would make for a good test case.

And FWIW, I still don't like the names of these helper functions. There isn't really much indication in the name what it is sign/zero extending from/to. Presume I want to do add/remove an instruction depending on whether the input is known to be sign-extended from a halfword to a doubleword, but not if it is only known to be sign-extended from a word to a doubleword, it isn't clear how I would use these functions to determine that.


https://reviews.llvm.org/D38988