[PATCH] D38724: [ELF] - Do not collect SHT_REL[A] sections unconditionally when --gc-sections and --emit-relocs used together.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 04:29:04 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D38724#898776, @ruiu wrote:

> Did you take a look why we had the assert? Can you explain why the assertion is there? I wonder if it makes sense.


Sure. We have is as a guard for internal logic of `MergeInputSection` I believe and it can easily be removed.
I prepared cleanup patch: https://reviews.llvm.org/D38996.
(It is almost completely independent from this one though).


https://reviews.llvm.org/D38724





More information about the llvm-commits mailing list