[PATCH] D38975: COFF: Don't add /manifest* flags to the response file.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 16 14:06:08 PDT 2017


pcc created this revision.

If /manifest:embed is enabled we're already creating a resource file
out of these flags and adding it to the linkrepro, and it doesn't
seem worth being able to repro side-by-side manifests.

No tests because this requires Windows and the linkrepro tests
require not-Windows.


https://reviews.llvm.org/D38975

Files:
  lld/COFF/Driver.cpp


Index: lld/COFF/Driver.cpp
===================================================================
--- lld/COFF/Driver.cpp
+++ lld/COFF/Driver.cpp
@@ -400,6 +400,12 @@
     case OPT_INPUT:
     case OPT_defaultlib:
     case OPT_libpath:
+    case OPT_manifest:
+    case OPT_manifest_colon:
+    case OPT_manifestdependency:
+    case OPT_manifestfile:
+    case OPT_manifestinput:
+    case OPT_manifestuac:
       break;
     default:
       OS << toString(Arg) << "\n";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38975.119214.patch
Type: text/x-patch
Size: 470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171016/61f0fcfb/attachment.bin>


More information about the llvm-commits mailing list