[PATCH] D38960: [Local] Fix a bug in the domtree update logic for MergeBasicBlockIntoOnlyPred.

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

In https://reviews.llvm.org/D38960#898723, @bmakam wrote:

> In https://reviews.llvm.org/D38960#898713, @kuhar wrote:
>
> > I think that this deserves a comment with a (partial) example, otherwise the change looks suspicious.
>
>
> Fair point. All the users of MergeBasicBlockIntoOnlyPred in the tree, do not pass DT to the function, so it is never exposed. Is there a way to test this in tree by passing DT to MergeBasicBlockIntoOnlyPred?


It shouldn't be difficult to turn it into a unit test. I haven't checked how Local.cpp is tested, but you can find some existing dominator tree test in IRTest/DominatorTree.cpp.


https://reviews.llvm.org/D38960