[PATCH] D38848: {ARM} IfConversion does not handle un-analyzable branch correctly

Kyle Butt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 16 09:52:35 PDT 2017


iteratee added inline comments.


================
Comment at: lib/CodeGen/IfConversion.cpp:1762
+    do {
+      ++RTIE;
+    } while (!RTIE->isBranch() && RTIE != RTIB);
----------------
This is backwards. Reverse iterators start at the last element and go 1 past the first.

RTIE should be const, and you should be incrementing RTIB


https://reviews.llvm.org/D38848





More information about the llvm-commits mailing list