[PATCH] D35816: [Greedy RegAlloc] Add logic to greedy reg alloc to avoid bad eviction chains

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Marina,

Looks reasonable to me.
Do a second pass before committing to make sure everything follow LLVM coding standard. I've highlighted a few problems.

I can help with that if you wish, but I figured you probably don't want to wait for me to do that :P.

Cheers,
-Quentin



================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:302
+  public:
+    /// \breif Clear all eviction information.
+    void Clear() { Evictees.clear(); }
----------------
brief*


================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:303
+    /// \breif Clear all eviction information.
+    void Clear() { Evictees.clear(); }
+
----------------
Use lower case for the first letter for methods.


================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:310
+    /// eviction info.
+    void ClearEvicteeInfo(unsigned Evictee) { Evictees.erase(Evictee); }
+
----------------
Ditto


================
Comment at: lib/CodeGen/RegAllocGreedy.cpp:1377
 
+/// \brief Chek if splitting Evictee will create a local split interval in basic
+/// block number BBNumber that may cause a bad eviction chain. This is intended
----------------
Check*


Repository:
  rL LLVM

https://reviews.llvm.org/D35816