[PATCH] D38937: [LLD] [COFF] Exclude certain static libraries and object files when exporting all symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D38937#898214, @ruiu wrote:

> At this point I feel like we should define a function `bool shouldExport(Defined *Sym)` or something, so that we can move the code to that function.


Sounds like a good idea. How do you suggest to handle the exclude `StringSet`s in that case - recreate them in each function invocation? Or have a `static StringSet<> ExcludeSymbols` in the global scope?

For future direction; GNU ld has got options for adding symbols and libraries to the exclude libs, so in case someone actually needs and wants that feature, we might need to add support for such options. I haven't felt a great need for it so far though, since I don't think I've ever seen it used.


https://reviews.llvm.org/D38937