[PATCH] D38928: [LoopInfo][Refactor] Make SetLoopAlreadyUnrolled a member function of the Loop Pass, NFC.
Hongbin Zheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 14 20:58:39 PDT 2017
etherzhhb added a comment.
In https://reviews.llvm.org/D38928#897918, @sanjoy wrote:
> LGTM
>
> I think the Loop class has grown quite a bit, and we should pull out some of the utility functions into a separate LoopUtils namespace, but this patch does not need to be blocked on that.
Just out of curiosity, what are the principle to tell whether a function should be a member function of the Loop class or a utilities?
Repository:
rL LLVM
https://reviews.llvm.org/D38928
More information about the llvm-commits
mailing list