[PATCH] D38588: Clear LastMappingSymbols and LastEMS(Info) when resetting the ARM(AArch64)ELFStreamer

[Yichao Yu via Phabricator via llvm-commits]

yuyichao updated this revision to Diff 119042.
yuyichao added a comment.

> I'm hoping for input from a code owner to see whether they think introducing a UnitTest is worth it.

I agree and I also just hope someone that knows better than me can just give a more definite answer....
I do like to point out that there's little ARM specific API used here so I'm not really sure who to ping about it ....

I striped down the Generator class as much as I can. I didn't realize that the `MCStreamer` was just passed to `AsmPrinter` so now the `AsmPrinter`, `TargetMachine` and all other variables that does not control hold object livetime are gone. Also removed all the error checkings.

Section names are changed to just `.foo`, `.bar`. Unrelated comments should be gone and added some comment that explain what this test is for/why it needs to be done this way to the best of my knowledge.


https://reviews.llvm.org/D38588

Files:
  lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp
  lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  unittests/Target/ARM/CMakeLists.txt
  unittests/Target/ARM/ELFStreamer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38588.119042.patch
Type: text/x-patch
Size: 5354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171014/5dcbbf3a/attachment.bin>