[PATCH] D38911: [cfi] Test cross-dso CFI on Android.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 13 17:14:53 PDT 2017


pcc added inline comments.


================
Comment at: compiler-rt/test/cfi/lit.cfg:43
+# Substitution to setup UBSAN_OPTIONS in portable way.
+config.substitutions.append(('%env_ubsan_opts=',
+                             'env UBSAN_OPTIONS=' + default_ubsan_opts_str))
----------------
Is this substitution being used?


================
Comment at: compiler-rt/test/lit.common.cfg:215
+  if android_api_level >= 26:
+    config.available_features.add('android-26');
+
----------------
Remove semicolon


https://reviews.llvm.org/D38911





More information about the llvm-commits mailing list