[PATCH] D38777: [wasm] readSection: Avoid reading past eof (fixes oss-fuzz #3219)

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 13 15:15:40 PDT 2017


JDevlieghere added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:1159
+          return;
+        return;
+      }
----------------
vsk wrote:
> vsk wrote:
> > JDevlieghere wrote:
> > > Should this be `continue`?
> > Oops! Yes. More to the point, the test doesn't cover this code.. I was wondering if you know how to test different error policies?
> Hm, maybe I should just leave this change out.
I don't think llvm-dwarfdump implements this yet: it just calls `DWARFContext::create` with the `defaultErrorHandler`. Could you add an option to specify the policy?


https://reviews.llvm.org/D38777





More information about the llvm-commits mailing list