[PATCH] D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf.

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked 5 inline comments as done.
dsanders added inline comments.


================
Comment at: utils/TableGen/CodeGenDAGPatterns.h:495
+  /// usable as part of an identifier.
+  std::string getImmTypeIdentifier() const;
 };
----------------
dsanders wrote:
> qcolombet wrote:
> > Ditto.
> Ok
Looking at this one a bit closer, I'm not sure I should move it. It makes use of other private members (immCodeUsesAPInt and immCodeUsesAPFloat) so I'd have to make those public to be able to move it. I don't think those other members should be public since they describe properties of getImmCode() which is also private.

Would it be ok with you to leave this one here?


https://reviews.llvm.org/D36569