[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation
Charles Saternos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 13 11:49:25 PDT 2017
ncharlie added inline comments.
================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:434
+ [&F](const FunctionSummary::EdgeTy &E) {
+ if (E.first.getGUID() == 0 || !E.first.getSummaryList().size())
+ return true; // might recurse - we can't reason about external
----------------
This is currently failing a test case that uses printf. Since printf doesn't have a summary associated with it (i.e. the SummaryList is empty), I can't determine if it recurses and have to fail out early.
Is there some spot I should add code to create a FunctionSummary for external functions?
https://reviews.llvm.org/D36850
More information about the llvm-commits
mailing list