[PATCH] D38825: [SCEV] Teach SCEV to find maxBECount when loop endbound is variant

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Analysis/ScalarEvolution.cpp:9701
+  APInt Limit =
+      IsSigned ? APInt::getSignedMaxValue(BitWidth) - (StrideForMaxBECount - 1)
+               : APInt::getMaxValue(BitWidth) - (StrideForMaxBECount - 1);
----------------
Maybe make it

  MaxValue = IsSigned ? APInt::getSignedMaxValue(BitWidth) : APInt::getMaxValue(BitWidth);
  Limit = MaxValue - (StrideForMaxBECount - 1);

to reduce code duplication? Just a suggestion.


https://reviews.llvm.org/D38825