[PATCH] D38786: Fix for Bug 30718 - Failure to disassemble certain MOV with rex.R

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:1487
+      index = regFromModRM(insn->modRM);                  \
       if (index > 5)                                      \
         *valid = 0;                                       \
----------------
I think the correct fix is to change this to "if ((index & 0x7) > 5)" We shouldn't be resampling modRM.


https://reviews.llvm.org/D38786