[lld] r315650 - Convert a few cases of isUndefined to isInCurrentDSO.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 12 17:23:35 PDT 2017


Author: rafael
Date: Thu Oct 12 17:23:35 2017
New Revision: 315650

URL: http://llvm.org/viewvc/llvm-project?rev=315650&view=rev
Log:
Convert a few cases of isUndefined to isInCurrentDSO.

I don't think there is an observable difference. We now just avoid
doing silly things like setting versions in lazy symbols.

Modified:
    lld/trunk/ELF/SymbolTable.cpp

Modified: lld/trunk/ELF/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=315650&r1=315649&r2=315650&view=diff
==============================================================================
--- lld/trunk/ELF/SymbolTable.cpp (original)
+++ lld/trunk/ELF/SymbolTable.cpp Thu Oct 12 17:23:35 2017
@@ -659,7 +659,7 @@ StringMap<std::vector<SymbolBody *>> &Sy
     DemangledSyms.emplace();
     for (Symbol *Sym : SymVector) {
       SymbolBody *B = Sym->body();
-      if (B->isUndefined())
+      if (!B->isInCurrentDSO())
         continue;
       if (Optional<std::string> S = demangle(B->getName()))
         (*DemangledSyms)[*S].push_back(B);
@@ -674,7 +674,7 @@ std::vector<SymbolBody *> SymbolTable::f
   if (Ver.IsExternCpp)
     return getDemangledSyms().lookup(Ver.Name);
   if (SymbolBody *B = find(Ver.Name))
-    if (!B->isUndefined())
+    if (B->isInCurrentDSO())
       return {B};
   return {};
 }
@@ -692,7 +692,7 @@ std::vector<SymbolBody *> SymbolTable::f
 
   for (Symbol *Sym : SymVector) {
     SymbolBody *B = Sym->body();
-    if (!B->isUndefined() && M.match(B->getName()))
+    if (B->isInCurrentDSO() && M.match(B->getName()))
       Res.push_back(B);
   }
   return Res;




More information about the llvm-commits mailing list