[PATCH] D38654: Parse DWARF information to reduce false positives.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 12 17:08:25 PDT 2017
probinson added inline comments.
================
Comment at: tools/llvm-cfi-verify/FileAnalysis.cpp:325
+ if (LineTable && !LineTable->Rows.empty()) {
+ LineInfoValid = true;
+ break;
----------------
Does this tool run only on .o files, and not on executables? Because this decides line info is valid if any CU has a non-empty line table. If you are looking at a linked executable, one might have been compiled -g and another not, and this check will still succeed.
================
Comment at: tools/llvm-cfi-verify/FileAnalysis.cpp:331
+ if (!LineInfoValid) {
+ for (auto &Range : DWARF->type_unit_sections()) {
+ for (auto &Unit : Range) {
----------------
Type units can have an associated line table, but that's just to provide filespecs for DW_AT_file. There should never be any Rows in a type unit's line table.
https://reviews.llvm.org/D38654
More information about the llvm-commits
mailing list