[llvm] r315644 - Removing default case statement from covered switch.
Keith Wyss via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 12 17:06:35 PDT 2017
Author: kpw
Date: Thu Oct 12 17:06:35 2017
New Revision: 315644
URL: http://llvm.org/viewvc/llvm-project?rev=315644&view=rev
Log:
Removing default case statement from covered switch.
Previous patch did not count on the llvm command line parser to restrict the
inputs, but it is safe to do so.
Fix forward for patch with details:
-- https://reviews.llvm.org/D38650 and
-- https://llvm.org/svn/llvm-project/llvm/trunk@315635 91177308-0d34-0410-b5e6-96231b3b80d8
Modified:
llvm/trunk/tools/llvm-xray/xray-stacks.cc
Modified: llvm/trunk/tools/llvm-xray/xray-stacks.cc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-xray/xray-stacks.cc?rev=315644&r1=315643&r2=315644&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-xray/xray-stacks.cc (original)
+++ llvm/trunk/tools/llvm-xray/xray-stacks.cc Thu Oct 12 17:06:35 2017
@@ -798,10 +798,6 @@ static CommandRegistration Unused(&Stack
ST.printAllAggregatingThreads<AggregationType::INVOCATION_COUNT>(
outs(), FuncIdHelper, StacksOutputFormat);
break;
- default:
- return make_error<StringError>(
- "Illegal value for aggregation-type.",
- make_error_code(errc::result_out_of_range));
}
} else {
switch (RequestedAggregation) {
@@ -813,10 +809,6 @@ static CommandRegistration Unused(&Stack
ST.printAllPerThread<AggregationType::INVOCATION_COUNT>(
outs(), FuncIdHelper, StacksOutputFormat);
break;
- default:
- return make_error<StringError>(
- "Illegal value for aggregation-type.",
- make_error_code(errc::result_out_of_range));
}
}
return Error::success();
More information about the llvm-commits
mailing list