[PATCH] D38766: [CVP] Process binary operations even when def is local

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

In https://reviews.llvm.org/D38766#895817, @apilipenko wrote:

> Did you measure the compile time impact somehow?


Compile time results on `CTMark` benchmarks show compile time is not affected by this change:

  Tests: 10
  Metric: compile_time
  
  Program                                        Patch   NoPatch           diff
  sqlite3/sqlite3                                35.23   35.53             0.8%
  tramp3d-v4/tramp3d-v4                          49.20   49.61             0.8%
  lencod/lencod                                  34.92   35.09             0.5%
  Bullet/bullet                                  54.23   54.02            -0.4%
  mafft/pairlocalalign                           20.22   20.29             0.3%
  SPASS/SPASS                                    29.78   29.87             0.3%
  7zip/7zip-benchmark                            79.72   79.50            -0.3%
  kimwitu++/kc                                   27.46   27.53             0.3%
  ClamAV/clamscan                                32.89   32.95             0.2%
  consumer-typeset/consumer-typeset              23.23   23.20            -0.1%

Also discussed offline with Philip (wrt change https://reviews.llvm.org/rL252032). LVI over time has been greatly improved to get rid of compile time bottlenecks, so the compile time reason to have the LocalDefs constraint is no longer that relevant.


https://reviews.llvm.org/D38766